-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unit test failure in DQM/Integration (issue 31592) #31593
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31593/18647
|
A new Pull Request was created by @guitargeek (Jonas Rembser) for master. It involves the following packages: L1TriggerConfig/L1GtConfigProducers @cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters: |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
An issue (#31592) appeared after the most recent BuilFile cleaning PR (#31548).
I guess the problem is that the BuildFile declares a normal library instead of an EDM plugin library, so that's what I suggest to change in this PR (inspired by [1]). Before my cleaning PR, this library was linked against by some other plugin, and that's how the plugin got registered in the past [2].
Now, the plugin can be found again with
edmPluginHelp -p L1GtTriggerMaskTechTrigTrivialProducer
and the previously-failing unit test succeeds.[1] https://github.com/cms-sw/cmssw/blob/master/RecoEgamma/EgammaPhotonProducers/BuildFile.xml
[2] https://github.com/cms-sw/cmssw/pull/31548/files#diff-d35b5dbd3e30c40bee4cc0c5bd6ae022L13
PR validation:
L1GtTriggerMaskTechTrigTrivialProducer
can be found once again withedmPluginHelp
./src/DQM/Integration/test/runtest.sh scal_dqm_sourceclient-live_cfg.py
passes againif this PR is a backport please specify the original PR and why you need to backport that PR:
No backport intended.